TerminatorNL / LagGoggles

A minecraft forge mod which visualises lag in the world
GNU General Public License v3.0
54 stars 20 forks source link

[issue?] Terrafirmacraft water isnt a tile entity, and shouldent be listed as one #118

Closed SpoilersMC closed 4 years ago

SpoilersMC commented 4 years ago

Basically laggoggles' world scan results thinks terrafirmacraft's water is a tile entity, and so floods the analysis report with multiple thousands of water block entries everything below the scroll bar's location is just water terrafirmacraft devs were very sure that water blocks arent tile entities

To Reproduce Run a world scan in a terrafirmacraft world

Versions Terrafirmacraft-1.2.1.144 LagGoggles-5.8-132 TickCentral-2.6 Forge-14.23.5.2847

TerminatorNL commented 4 years ago

In this case, single entities also mean single blocks. Even though it's a single class instance that's used for all the blocks, We call them entities here, because we can trace the position of the blocks with their coordinates. To the end user, this makes more sense.

SpoilersMC commented 4 years ago

the issue wasnt that theres thousands of them, theres thousands of them because theres thousands of water blocks the issue is that they show up at all TFC water shouldent be identified as tiles in the first place...

TerminatorNL commented 4 years ago

I am unsure what the problem is here, we might be miscommunicating.

Basically laggoggles' world scan results thinks terrafirmacraft's water is a tile entity

This is incorrect. LagGoggles thinks its a block. As I stated in my previous comment, it will be displayed to the user as an entity as per the official definition of the word entity. A single object, or: "a thing with distinct and independent existence"

Even a block of grass or leaves could show up on that list, you might even find them at the bottom! All blocks receive a random tick update depending on the randomTickSpeed gamerule. My guess is that TFC just happens to be slightly slower whilst random updating, combined with a low (0?) LagGoggles minimum threshold, and thus: makes it to the list.

As far as I can tell: This is intended behavior