search

TerminatorNL / LagGoggles

A minecraft forge mod which visualises lag in the world
GNU General Public License v3.0
54 stars 20 forks source link

LAN permission enforcement, or better description in config #66

Open Laike-Endaril opened 5 years ago

Laike-Endaril commented 5 years ago

Description:

This issue is a spinoff of another issue that I created and closed, due to my own misunderstanding (#65)

The permission level in the server config settings applies to dedicated only.

Personally I think it would be good to have control over permissions for LAN games as well, but I understand that is somewhat a niche interest.

If LAN permissions are not planned, a better description in the server config stating that the setting only applies to dedicated, and not to SP or LAN, might be a good idea. It would prevent (at least most) future misunderstandings.

TerminatorNL commented 5 years ago

I was quite surprised to see you testing LAN permissions in your previous report (#65) Simply, because I didn't even think to test it, ever. ¯\_(ツ)_/¯

In the rewrite I have a more advanced permission system set-up (Much like Tiquality, where Sponge is used if it's present). It should be simple to differentiate between SP and LAN by checking the player instance used, so I'll include that.

As for documentation... I guess you're right, I should have mentioned that it only affects dedicated servers. I assumed everyone playing SP effectively is an operator, which isn't always the case when you open it up to LAN.

Thank you for digging deep into this problem, like cracking open the source and testing what's going on yourself. That was really awesome to see, especially since I have my hands full at the moment.

I'll make a quick commit to state that it only affects dedicated servers, but I don't think it's release worthy at the moment since it doesn't change functional behaviour.

Again, thanks for the effort!

TerminatorNL commented 5 years ago

I am going to leave this issue open to make sure I include SP/LAN/Dedicated server differentiation in the rewrite.

Laike-Endaril commented 5 years ago

Np, thanks, and good luck o/