TerminatorNL / LagGoggles

A minecraft forge mod which visualises lag in the world
GNU General Public License v3.0
54 stars 20 forks source link

Crash with version 4.8 #75

Closed Gunner76th closed 5 years ago

Gunner76th commented 5 years ago

Describe the bug A clear and concise description of what the bug is. During startup the client crashes but does not generate a crash report because laggoggles issues an internal shutdown order to the client.

To Reproduce Steps to reproduce the behavior Add Lag Goggle version 4.8 to an instance of StoneBlock 2 version 1.15.0 as found on the Twitch launcher. https://www.curseforge.com/minecraft/modpacks/ftb-presents-stoneblock-2

This error affects both FAT and THIN versions in the client environment. In the server environment there is no issues.

If you are using SpongeForge, which version are you using? N/A

Please provide the early startup messages starting with [LagGoggles-Boot]

Example:

Replace me!
[20:37:32] [main/INFO]: I am located here: file:\C:\Users\Codey\Documents\Curse\Minecraft\Instances\FTB%20Presents%20Stoneblock%202\mods\LagGoggles-FAT-1.12.2-4.8.jar!\cf\terminator\laggoggles\Main.class
[20:37:32] [main/INFO]: I am designed for Forge version: 14.23.5.2838
[20:37:32] [main/INFO]: Loading client classes
[20:37:32] [main/INFO]: SpongeForge is not present!
[20:37:32] [main/INFO]: We're running in a production environment.

This is from the top of the latest.log file showing that the correct version of forge is in fact being used.

[20:37:26] [main/INFO]: Using primary tweak class name net.minecraftforge.fml.common.launcher.FMLTweaker
[20:37:26] [main/INFO]: Calling tweak class net.minecraftforge.fml.common.launcher.FMLTweaker
[20:37:26] [main/INFO]: Forge Mod Loader version 14.23.5.2838 for Minecraft 1.12.2 loading
[20:37:26] [main/INFO]: Java is Java HotSpot(TM) 64-Bit Server VM, version 1.8.0_221, running on Windows 10:amd64:10.0, installed at C:\Program Files\Java\jre1.8.0_221
[20:37:27] [main/INFO]: Searching C:\Users\Codey\Documents\Curse\Minecraft\Instances\FTB Presents Stoneblock 2\mods for mods

If you used the word 'error' somewhere, always provide the stack trace along with both debug.log and latest.log Twtich does not create a debug.log file, therefore no debug.log file can be supplied. Attached is the latest.log file. latest.log

TerminatorNL commented 5 years ago

This part is of interest:

[20:39:02] [Client thread/INFO]: Loading mixin target class: net.minecraft.entity.Entity
[20:39:02] [Client thread/FATAL]: Not all required mixins have been applied!
[20:39:02] [Client thread/FATAL]: To prevent you from wasting your time, the process has ended.
[20:39:02] [Client thread/FATAL]: 
[20:39:02] [Client thread/FATAL]: Required mixins that have not been applied:
[20:39:02] [Client thread/FATAL]: - cf.terminator.laggoggles.mixin.MixinEntity targeting: net.minecraft.entity.Entity
[20:39:02] [Client thread/FATAL]: 
[20:39:02] [Client thread/FATAL]: This means that LagGoggles will not function properly.
[20:39:02] [Client thread/FATAL]: Make sure your versions are correct for Forge as well as SpongeForge.
[20:39:02] [Client thread/FATAL]: 

This happens when p455w0rdlib is installed. I did a deep-dive into this issue in #71.

I have sent a request to address it here: https://github.com/p455w0rd/p455w0rds-Library/issues/26#issuecomment-513769905

Sadly, this isn't an issue I am able to fix, since it's not LagGoggles.

LagGoggles just makes sure its mixins have been applied and make sure you don't waste your time with a broken installation.

Gunner76th commented 5 years ago

Thank you for this update. In addition I have tagged onto a recent bug report that another user opened with p455w0rd's library about this issue. It would seem that he has updated the mod to version 156, however I am unable to verify if it did in fact resolve the issue since he failed to also update his other mods to be compatible with this newer version.

https://github.com/p455w0rd/p455w0rds-Library/issues/45

So at this point, even if he has resolved the issue in 156, because his other mods cannot run because of a dependency issue, his fix at this junction in time is moot. Hopefully we see this resolved quickly.

TerminatorNL commented 5 years ago

I hope so too! Thank you for reaching out to the developer. Now we know it's being worked on :+1:

p455w0rd commented 5 years ago

It's literally only /dank/null. Way to lie and overexaggerate Gunner, cuz that always helps. Remove /dank/null and shit works.

TerminatorNL commented 5 years ago

Thank you for looking into this, @p455w0rd