search

TerminatorNL / Tiquality

Make server lag the problem of the source player.
https://www.curseforge.com/minecraft/mc-mods/tiquality
GNU General Public License v3.0
23 stars 13 forks source link

[Bug] Incompatible with Laggoggles #47

Open clienthax opened 4 years ago

clienthax commented 4 years ago

Describe the bug

[22:09:57] [Server thread/INFO] [laggoggles]: Loading mixin target class: net.minecraft.world.WorldServer
[22:09:57] [Server thread/FATAL] [laggoggles]: Not all required mixins have been applied!
[22:09:57] [Server thread/FATAL] [laggoggles]: To prevent you from wasting your time, the process has ended.
[22:09:57] [Server thread/FATAL] [laggoggles]: 
[22:09:57] [Server thread/FATAL] [laggoggles]: Required mixins that have not been applied:
[22:09:57] [Server thread/FATAL] [laggoggles]: - cf.terminator.laggoggles.mixin.MixinWorldServerSponge targeting: net.minecraft.world.WorldServer
[22:09:57] [Server thread/FATAL] [laggoggles]: 
[22:09:57] [Server thread/FATAL] [laggoggles]: This means that LagGoggles will not function properly.
[22:09:57] [Server thread/FATAL] [laggoggles]: Make sure your versions are correct for Forge as well as SpongeForge.
[22:09:57] [Server thread/FATAL] [laggoggles]: 
[22:09:57] [Server thread/WARN] [FML]: Java has been asked to exit (code 1)
[22:09:57] [Server thread/WARN] [FML]: Exit trace:
[22:09:57] [Server thread/WARN] [FML]:  cf.terminator.laggoggles.mixinhelper.MixinValidator.validate(MixinValidator.java:53)
[22:09:57] [Server thread/WARN] [FML]:  cf.terminator.laggoggles.Main.preinit(Main.java:33)
[22:09:57] [Server thread/WARN] [FML]:  sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[22:09:57] [Server thread/WARN] [FML]:  sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[22:09:57] [Server thread/WARN] [FML]:  sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[22:09:57] [Server thread/WARN] [FML]:  java.lang.reflect.Method.invoke(Method.java:498)
[22:09:57] [Server thread/WARN] [FML]:  net.minecraftforge.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:637)
[22:09:57] [Server thread/WARN] [FML]:  sun.reflect.GeneratedMethodAccessor13.invoke(Unknown Source)
[22:09:57] [Server thread/WARN] [FML]:  sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[22:09:57] [Server thread/WARN] [FML]:  java.lang.reflect.Method.invoke(Method.java:498)
[22:09:57] [Server thread/WARN] [FML]:  com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)
[22:09:57] [Server thread/WARN] [FML]:  com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)
[22:09:57] [Server thread/WARN] [FML]:  com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)
[22:09:57] [Server thread/WARN] [FML]:  com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)
[22:09:57] [Server thread/WARN] [FML]:  com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)
[22:09:57] [Server thread/WARN] [FML]:  com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)
[22:09:57] [Server thread/WARN] [FML]:  com.google.common.eventbus.EventBus.post(EventBus.java:217)
[22:09:57] [Server thread/WARN] [FML]:  net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:219)
[22:09:57] [Server thread/WARN] [FML]:  net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:197)
[22:09:57] [Server thread/WARN] [FML]:  sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[22:09:57] [Server thread/WARN] [FML]:  sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[22:09:57] [Server thread/WARN] [FML]:  sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[22:09:57] [Server thread/WARN] [FML]:  java.lang.reflect.Method.invoke(Method.java:498)
[22:09:57] [Server thread/WARN] [FML]:  com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)
[22:09:57] [Server thread/WARN] [FML]:  com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)
[22:09:57] [Server thread/WARN] [FML]:  com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)
[22:09:57] [Server thread/WARN] [FML]:  com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)
[22:09:57] [Server thread/WARN] [FML]:  com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)
[22:09:57] [Server thread/WARN] [FML]:  com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)
[22:09:57] [Server thread/WARN] [FML]:  com.google.common.eventbus.EventBus.post(EventBus.java:217)
[22:09:57] [Server thread/WARN] [FML]:  net.minecraftforge.fml.common.LoadController.redirect$forgeImpl$PostEvent$zza000(LoadController.java:568)
[22:09:57] [Server thread/WARN] [FML]:  net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:136)
[22:09:57] [Server thread/WARN] [FML]:  net.minecraftforge.fml.common.Loader.preinitializeMods(Loader.java:629)
[22:09:57] [Server thread/WARN] [FML]:  net.minecraftforge.fml.server.FMLServerHandler.beginServerLoading(FMLServerHandler.java:99)
[22:09:57] [Server thread/WARN] [FML]:  net.minecraftforge.fml.common.FMLCommonHandler.onServerStart(FMLCommonHandler.java:333)
[22:09:57] [Server thread/WARN] [FML]:  net.minecraft.server.dedicated.DedicatedServer.func_71197_b(DedicatedServer.java:125)
[22:09:57] [Server thread/WARN] [FML]:  net.minecraft.server.MinecraftServer.run(MinecraftServer.java:486)
[22:09:57] [Server thread/WARN] [FML]:  java.lang.Thread.run(Thread.java:813)
[22:09:57] [Server Shutdown Thread/INFO] [net.minecraft.server.MinecraftServer]: Stopping server

To Reproduce Steps to reproduce the behavior LagGoggles-FAT-1.12.2-4.9.jar

Which Forge version are you using? forge-1.12.2-14.23.5.2847-universal.jar

Which SpongeForge version are you using? spongeforge-1.12.2-2838-7.1.8-RC3970.jar

Please provide the early startup messages starting with [Tiquality-Boot]

[22:08:28] [main/INFO] [Tiquality-Boot]: I am located here: file:/home/container/./mods/Tiquality-FAT-1.12.2-GAMMA-1.7.2.jar!/com/github/terminatornl/tiquality/Tiquality.class
[22:08:28] [main/INFO] [Tiquality-Boot]: I am designed for Forge version: 1.12.2-14.23.5.2838
[22:08:28] [main/INFO] [Tiquality-Boot]: Loading server classes
[22:08:28] [main/INFO] [Tiquality-Boot]: SpongeForge is present!
[22:08:28] [main/INFO] [Tiquality-Boot]: I am designed for SpongeForge version: 1.12.2-2838-7.1.7-RC3886
[22:08:28] [main/WARN] [Tiquality-Boot]: SpongeForge version is different than expected!
[22:08:28] [main/WARN] [Tiquality-Boot]: This could result in undefined behavior.
[22:08:28] [main/WARN] [Tiquality-Boot]: 
[22:08:28] [main/WARN] [Tiquality-Boot]: Expected: '1.12.2-2838-7.1.7-RC3886', but you have: '1.12.2-2838-7.1.8-RC3970' installed.
[22:08:28] [main/INFO] [Tiquality-Boot]: We're running in a production environment.

If you used the word 'error' somewhere, always provide the stack trace along with both debug.log and latest.log

TerminatorNL commented 4 years ago

This is correct, both Tiquality and LagGoggles try to inject themselves in the same methods to perform profiling. This is why I had to rewrite LagGoggles for the next major version.

Even worse, when Tiquality is installed, LagGoggles will report false timings, because it could start timing other blocks (Tiquality takes over)

TerminatorNL commented 4 years ago

https://github.com/TerminatorNL/LagGoggles/issues/97