search

Terpo / Waterworks

Waterworks Mod for Minecraft
MIT License
5 stars 0 forks source link

Add configurable liquid source block for pump #79

Open Foreck1 opened 4 years ago

Foreck1 commented 4 years ago

[1.12] Hi, currently there's no way to make the water pump generate water from "aquifers" other than bedrock. In most cases this isn't a problem at all, but that becomes a problem with mods such as Vertically Stacked Dimensions or Cubic Chunks where bedrock isn't usually the "bedrock". Would it be possible to add a config for either adding valid block sources of infinite water (could also be useful if a biome option could be added) or a layer at which water can be gathered? Thanks for your time.

Terpo commented 4 years ago

I am not sure if I have time to add extra features to 1.12.

Currently there should be an option for skyblock maps, where y = 0 is defined as bedrock. The major question is, if the y coordinate still exists in the mods you mentioned. So, would it be the easiest way to define a config option to change the y coordinate. In this case the pump would simply place pipes until the given y coordinate and then start working.

Another option would be some kind of "valid bedrock blocks" but normally this would not make any sense. Most blocks can be obtained and placed. So you can simply reduce the amount of pipes to one by placing a required block two blocks below the pump.

But as I said, I am not sure if I can handle this. My spare time is really limited, 1.16 is waiting for a port and even the extended fluid stuff is not ported up to 1.15. The next time frame where I can get some work done is mid august.

Foreck1 commented 4 years ago

Thanks for answering, I realize you time is precious and this is an old (although still pretty active) version. Either of those two solutions you offer would suffice. "but normally this would not make any sense" I think is something that's up for the modpack maker to decide, examples may include adding a rarely spawning block which does not drop itself upon being mined, unbreakable blocks or "technical" blocks such as Vertically Stacked Dimensions' portal blocks.

Whatever you can done is much appreciated, but you come first, so no worries. Good luck!

Terpo commented 4 years ago

So, my time frame with some free space is nearly over and I have decided to skip any futher features for older versions. If you find someone who is willing to create a pull request that solves your needs, then go for it.