search

TerraFirmaCraft-The-Final-Frontier / FileDirector

Automated mod/file downloading.
https://www.curseforge.com/minecraft/mc-mods/filedirector
MIT License
8 stars 5 forks source link

URL encoding is missing #19

Closed juraj-hrivnak closed 1 week ago

juraj-hrivnak commented 6 months ago

URLs with a whitespace or a special character like § fail to download. A proper URL encoding for URLs would be appreciated.

I can recommend this library (the JVM version of it).

juraj-hrivnak commented 6 months ago

Here is my log: https://mclo.gs/gm2ejws And here is my config: mod-director.zip

ACGaming commented 1 month ago

Certainly not the nicest approach, but this works just fine:

{
    "url": "https://mediafilez.forgecdn.net/files/2668/311/%C2%A7c%C2%A7lCream%20%C2%A77Cuisine%20Resource%20Pack%20-%200.5.0.zip",
    "folder": "resourcepacks"
}
juraj-hrivnak commented 1 month ago

Thanks. I tried this before and it did not work. Has anything changed since then?

ACGaming commented 1 month ago

Untouched for a longer time, tested with 1.8.3.

juraj-hrivnak commented 2 weeks ago

Okay, that works. I fixed it for Pakku. If this is ever gonna change, I hope it stays backwards compatible with the encoded URLs.

juraj-hrivnak commented 3 days ago

The problem is again that the encoded file names don't decode, so you end up with file names like this: %C2%A7c%C2%A7lCream%20%C2%A77Cuisine%20Resource%20Pack%20-%200.5.0.zip