TerraFirmaCraft-The-Final-Frontier / RoughlyEnoughIDs

Fork of JustEnoughIDs. Minecraft 1.13+ chunk format in 1.12.2, removing the block, item, & biome ID limits.
https://www.curseforge.com/minecraft/mc-mods/reid
MIT License
10 stars 11 forks source link

Fix incompatibility with Astral Sorcery's resplendent prism #16

Closed jchung01 closed 1 year ago

jchung01 commented 1 year ago

Rewrites MixinEnchantmentHelper to avoid using @Overwrites to offer better compatibility with other coremods (i.e. Astral Sorcery's) modifying the same class.

Provides a fix on JEID/REID's side for DimensionalDevelopment/JustEnoughIDs#136, which may be desirable for users/pack makers that need this fix outside of SevTechAges (as they use SevPatches, which requires all mods that it patches). This does NOT fix the other mentioned problem:

Astral uses short Enchantment IDs in EnchantmentUpgradeHelper, leaving it incompatible with IDs over 255.

as that would require a mixin into Astral Sorcery, which whether that is allowed is questionable at best due to its license (even if SevPatches does it).

This rewrite means in practice, when using JEID/REID with AS, the AS resplendent prism actually modifies enchantment levels as it should (assuming other coremods don't break it like Enchantments Control).