TerraFirmaCraft-The-Final-Frontier / RoughlyEnoughIDs

Fork of JustEnoughIDs. Minecraft 1.13+ chunk format in 1.12.2, removing the block, item, & biome ID limits.
https://www.curseforge.com/minecraft/mc-mods/reid
MIT License
10 stars 11 forks source link

Crash in Dev Environment #25

Open TheComputerizer opened 9 months ago

TheComputerizer commented 9 months ago

When running in a dev environment for the tweaks mod of my pack (which is big enough to need JEID/REID), I get this crash whenever I attempt to join a world that has already been made. When I make a new world I can create and load the world fine, but I sometimes randomly get this similar crash. It's possible this could be an incompatibility with CensoredASM or maybe the FancyGradle ASM patch, but it would be cool if at least a null check could be added to JEIDTransformer#getIdFromPotEffect

jchung01 commented 2 months ago

As of 2.1.0 that method is no longer used, so feel free to test the latest version in dev.