search

TerraFirmaCraft-The-Final-Frontier / RoughlyEnoughIDs

Fork of JustEnoughIDs. Minecraft 1.13+ chunk format in 1.12.2, removing the block, item, & biome ID limits.
https://www.curseforge.com/minecraft/mc-mods/reid
MIT License
10 stars 11 forks source link

Scape & Run: Parasites nodes cannot overwrite biomes with their own. #4

Closed Lylythii closed 5 months ago

Lylythii commented 1 year ago

Quote, re-CurseForge comment; https://www.curseforge.com/minecraft/mc-mods/reid?comment=20

Scape and Run: Parasite (SRP for short) has a gameplay mechanic where a "node" appears and starts to replace the biome with its own to spread the 'infestation'. The issue is, when JEID (or REID) is installed it cant override the biomes with its own biome. also i found issue #175 on JEID's github: https://github.com/DimensionalDevelopment/JustEnoughIDs/issues/175

i didnt know SRP wasnt open-source, but they have a discord where they are discussing issues with the mod.

Vetpetmon commented 1 year ago

Dhantry will have to give you permissions to see/use the mod's code for patching and compiling; I was only given permissions to have some of the relevant code available for making the Mixin; however, due to the entire dependency tree for SRP's nodes being needed to compile the mod after putting in the patch, I never got my patch in action at all, so I have not a clue if it works or not.

If he gives you permissions, I will send you over my untested patch. Be aware that you should make it a flat (local) repository that is ignored by github in order to respect the devs' wishes as they don't want the code to be publicly available.

This is basically a years-long issue, and I'm glad to see that someone is reviving JEID after DimDev abandoned it.

Vetpetmon commented 1 year ago

https://github.com/Vetpetmon/JustEnoughIDs-SRP-fix This repository has seen activity for once, and I've forwarded it to SRP devs to see if they can get it to compile, because I don't have the source code at all.

I will let you know if my patch works, and if it does, I will make a PR with my patches. However, do realize this can make you unable to compile until you have the source code (with permission).

Lylythii commented 1 year ago

I will let you know if my patch works, and if it does, I will make a PR with my patches. However, do realize this can make you unable to compile until you have the source code (with permission).

So long as it works I'll be happy to merge such a PR. I'll reach out to the SRP devs soon & request permission to use their code for compiling purposes. I was not aware of your fork!

Vetpetmon commented 1 year ago

I deliver an update on how the patch is going:

It works, but works horribly. A lot of code on SRP's end would need to be re-written to make patching it easier.

SRP looks for a biome match, but this instanceof [insert biome here] with JEID/REID breaks entirely, causing blocks to only spread the biome, not the biome spreading blocks. additionally, biome changes are not saved onto disk, only memory.

ralseilii commented 1 year ago

same issue and this issue made modpack of srp impossible