TerraFirmaCraft-The-Final-Frontier / RoughlyEnoughIDs

Fork of JustEnoughIDs. Minecraft 1.13+ chunk format in 1.12.2, removing the block, item, & biome ID limits.
https://www.curseforge.com/minecraft/mc-mods/reid
MIT License
10 stars 11 forks source link

Add compatibility for Chunk-Pregenerator #44

Closed jchung01 closed 4 months ago

jchung01 commented 4 months ago

Seems like a relatively simple fix, should mean the Chunk-Pregenerator mod is compatible now. This is the only mod that I'm aware of that triggers the associated if block, that is:

if getBiome is called before the biome array is initialised the provider is queried to find the expected biome.

(taken from https://github.com/DimensionalDevelopment/JustEnoughIDs/issues/42#issuecomment-520286560) Tested seed -107391545297039861 on SP and the pregenerated chunks from Chunk-Pregenerator seem to have the correct biome now. Fixes #14, #40, DimensionalDevelopment/JustEnoughIDs#42.

BinBashBanana commented 4 months ago

Thank you!!!