TerraFirmaGreg-Team / Modpack-Modern

An innovative modpack that contains GregTech and TerraFirmaCraft on 1.20.x.
GNU General Public License v3.0
58 stars 13 forks source link

[Bug] Any tool head that has no TFC counterpart cannot crafted into tool #345

Closed chemlzh closed 5 months ago

chemlzh commented 5 months ago

Version modpack Used

0.7.7

Environment

Singleplayer

New Worlds

No

Expected Behavior

Spade head & stick can be used to craft spade.

(Update) Any tool head can be used to craft tool with a stick.

Actual Behavior

Spade head & stick cannot be used to craft spade. Instead, the original GTM crafting method still remains.

(Update) Any tool head that has no TFC counterpart cannot crafted into tool with a stick. Instead, the original GTM crafting method still remains.

Steps to Reproduce

  1. Extrude a spade head with 2 ingots.
  2. Try to craft spade with a spade head and a stick.

This also suits with other tool head that has no TFC counterpart (except for mining hammer).

Additional Information

Original GTM crafting recipe for spade ramains.

image

Spade head has no use as for version 0.7.7.

image

And could you please tell me where the crafting recipe with toolhead is? I'll try to fix it.

(Update) Butchery knife head cannot be crafted into butchery knife.

image

Screwdriver tip can only be crafted into electronic screwdriver. Non-electronic screwdriver cannot be crafted.

image

I have found that whether toolhead to tool recipes exist is defined by code below (in kubejs\server_scripts\gregtech\recipes.js)

    GTMaterialRegistry.getRegisteredMaterials().forEach(material => {
        //#region Рецепты инструментов

        if (material.hasFlag(TFGMaterialFlags.HAS_TFC_TOOL)) {
            global.GTCEU_ANVIL_TOOL_TYPES.forEach(toolType => {
                let toolStack = ToolHelper.get(toolType, material)

                event.recipes.tfc.advanced_shaped_crafting(TFC.itemStackProvider.of(toolStack).copyForgingBonus(), [
                    'A',
                    'B'
                ], {
                    A: `gtceu:${material.getName()}_${toolType.name}_head`,
                    B: '#forge:rods/wooden'
                }, 0, 0).id(`gtceu:shaped/${toolType.name}_${material.getName()}`)

            })
        }

It seems that TFGMaterialFlags has not included butchery head, screwdriver and spade. However, I cannot edit TFG-core, so I have to seek help from you. @Exzept1on @Xikaro

Exzept1on commented 5 months ago

Fixed, but screwdrivers, ohhhhh, its gtceu bug.