TerraFusion / basicFusion

Terra Basic Fusion Project - University of Illinois
Other
2 stars 0 forks source link

ASTER failing to get Gain Status #199

Closed LandonTClipp closed 7 years ago

LandonTClipp commented 7 years ago

ASTER retrieves the gain status for each camera from productmetadata.0. It searches for HGH, NOR, LO1, LO2, and OFF. However in the file

/u/sciteam/clipp/scratch/BFDataNew/BFData/ASTER/2013.12.27/AST_L1T_00312272013225732_20150619040038_13845.hdf

Some of the cameras have "LOW" as the status. ASTER does not check for this???

The error that manifests is "There is no valid Unit Conversion Coefficient for this dataset ImageData2". Need to figure out how to fix this problem.

kyang2014 commented 7 years ago

According to ASTER user's guide, The HGH, NOR, LO1, LO2, and OFF are all they provided. So this LOW must be an outlier. I will double check the file, hang on.

ASTER-radiance-calculation..pdf

LandonTClipp commented 7 years ago

This file path is for Blue waters, FYI

kyang2014 commented 7 years ago

Landon, I verified what you said. We need to contact ASTER team on this issue. You should notify Guangyu and ask him to contact LP DAAC how we should interpret the LOW. This is not in their user's guide.

kyang2014 commented 7 years ago

From Guangyu: On page 13 of the ASTER 1T product specification (https://lpdaac.usgs.gov/sites/default/files/public/product_documentation/aster_l1t_product_specification.pdf), you will see the gain markers for VNIR (Bands 1-3) are “HIGH”, “NOR” or “LOW”. But for SWIR, they are “HIGH”, “NOR” , “LO1” or “LO2”.

I’ve looked at the sample ASTER file and found the gain settings for bands 1 and 2 are indeed set to “Low”.
Note that there are no conversion coefficients for “LO2” setting for Bands 1, 2, and 3N in table 2-3. So if the gain setting is “LOW” for these three bands, the conversion coefficients for “LO1" have to be used.

kyang2014 commented 7 years ago

Landon, could you provide me the inputfilelist for this at roger?

LandonTClipp commented 7 years ago

The input file list for ROGER:

/projects/TDataFus/fusionTesting/input/2013/input74612.txt

LandonTClipp commented 7 years ago

I have changed the ASTER code so that any time cameras 1, 2, or 3N are found with a gain label of "LOW", it remaps this internally to the "LO1" label, as per what Dr. Zhao suggested. This seems to have fixed the problem.

Given that no other issues pop up, this should now give us >99% success rate for 2013 processing. I will submit another job to Blue Waters to test everything we have so far.

kyang2014 commented 7 years ago

landon, we are duplicating our work :) I am going to check in the change and my change is simple. Could you revert your ASTER.c and I can check in my change?

@@ -1679,10 +1679,10 @@ short get_band_index(char band_index_str) short get_gain_stat(char gain_stat_str) {

LandonTClipp commented 7 years ago

Okay I will revert my work. Please do not merge to master until I revert the change.

LandonTClipp commented 7 years ago

Dr. Yang, go ahead and push your changes to this specific portion of ASTER to a development branch. I made other changes to ASTER, namely adding more robust error checks. I am afraid that if you try to push to master, you will run into conflicts. I will simply copy-paste your version of this bug-fix to ASTER.c

kyang2014 commented 7 years ago

Done with the branch temp_aster_fix. Note the ASTER.c is based on the version before you reverted. Please just add your error handling code/comments to this file and check it into the master. I've checked it with the ASTER files that have low with my version. The values look correct.

LandonTClipp commented 7 years ago

Your changes have been successfully merged. I will begin the next round of BW tests.