Correct line-end handling on Windows

Terracotta-OSS / galvan

An integration testing framework.

Apache License 2.0

1 stars 16 forks source link

Correct line-end handling on Windows #190

Closed cljohnso closed 6 years ago

cljohnso commented 6 years ago

This commit prevents Galvan, when used on Windows, from emitting blank lines and double-spaced lines to the console and file output, respectively.

Fixes #189

cljohnso commented 6 years ago

Another file, org.terracotta.testing.logging.VerboseOutputStream, also has logic to pre-process lines using \n as the line separator but tests showed that mods to org.terracotta.testing.common.SimpleEventingStream were sufficient.

I tested this using a locally-built Galvan library.

I added @cschanck as a reviewer since he's a Windows user and can more directly observe the result.

cljohnso commented 6 years ago

@myronkscott can you please do a local test on *NIX to ensure I didn't break anything?