search

Terracotta-OSS / terracotta-apis

Apache License 2.0
6 stars 25 forks source link

Connection.getEntityRef should throw ConnectionClosedException #206

Open jd0-sag opened 7 years ago

jd0-sag commented 7 years ago

During the recent change to formalize the exception path through existing end-points and in-flight messages, we didn't also look at the paths to create new end-points.

Ideally, this would be documented to throw this new exception, as well.

mathieucarbou commented 7 years ago

@ChrisGreenaway @myronkscott : I am linking this with #215 also because we also ran into this issue. We are always using timed out invokations for voltron and when voltron closes the connection, we have no way to know and if we do a connection.getEntityRef(), it will block indefinitely.

So if we had #215 in place, we could know that the connection is closed and that we cannot use it.

myronkscott commented 7 years ago

I believe this to be occurring already. Confirm then close.