search

Terracotta-OSS / terracotta-apis

Apache License 2.0
6 stars 25 forks source link

client version in cluster state dumps. #312

Open GaryWKeim opened 5 years ago

GaryWKeim commented 5 years ago

https://github.com/Terracotta-OSS/terracotta-platform/pull/540

https://github.com/Terracotta-OSS/terracotta-core/pull/1044

anthonydahanne commented 5 years ago

@myronkscott can you please add your review ? thanks

myronkscott commented 5 years ago

I have a concern that in rare cases, this change may crash the cluster. If a stripe split-brains, then heals, the active will as the other active for information that includes this serialized object. I know it is not a great solution, but maybe we should include version information as part of the UUID.

myronkscott commented 5 years ago

I think the best way to handle this is to add a new sub-class of PlatformConnectedClient which includes the version.

anthonydahanne commented 5 years ago

hello, @myronkscott do you want me or @GaryWKeim to add this new subclass ?

myronkscott commented 5 years ago

hello, @myronkscott do you want me or @GaryWKeim to add this new subclass ?

I think we need to discuss. Even a subclass is bad as a legacy server will not have the sub-class and cause problems.