search

Terracotta-OSS / terracotta-platform

http://terracotta.org
Apache License 2.0
32 stars 48 forks source link

[DO NOT MERGE] log directory can be unset so its presence is not required. #1108

Closed mathieucarbou closed 2 years ago

tmesic99 commented 2 years ago

What happens if we start an unconfigured node with no config-dir defined, and then activate it - still without a defined config-dir. Is that a desirable/valid state we want to support?

mathieucarbou commented 2 years ago

you mean log-dir instead of config-dir ? If yes, then yes we have always supported not having any log dir because the value is UNSET everywhere like backup dir.

mathieucarbou commented 2 years ago

Note: I was able to test locally that this works:

./kit/target/platform-kit-5.9-SNAPSHOT/platform-kit-5.9-SNAPSHOT/server/bin/start-tc-server.sh -auto-activate -cluster-name=foo -log-dir=

We get the line:

2022-07-21 23:12:19,866 INFO - Logging directory is not set. Logging only to the console

mathieucarbou commented 2 years ago

Needs discussion because break backward compat'

mathieucarbou commented 2 years ago

I will recreate a new PR