search

Terracotta-OSS / terracotta-platform

http://terracotta.org
Apache License 2.0
32 stars 48 forks source link

Fix server plugins packaging: #1110

Closed mathieucarbou closed 2 years ago

mathieucarbou commented 2 years ago

I have verified with the following that we do not have nay ref to logback or slf4j inside class-path entries of jars on the server/plugins path:

for jar in `find kit/target/platform-kit-5.9-SNAPSHOT/platform-kit-5.9-SNAPSHOT/server/plugins -name "*.jar"`; do echo $jar; unzip -p $jar META-INF/MANIFEST.MF | grep -A 8 -i Class-Path | grep -i slf4j; done;

for jar in `find kit/target/platform-kit-5.9-SNAPSHOT/platform-kit-5.9-SNAPSHOT/server/plugins -name "*.jar"`; do echo $jar; unzip -p $jar META-INF/MANIFEST.MF | grep -A 8 -i Class-Path | grep -i logback; done;
mathieucarbou commented 2 years ago

This makes sense. Did you validate it works in the TC-EE kit still?

Sadly I cannot without Clifford's work but considering the EE kit is just this kit with some more plugins, I don't see any reasons why it should not.

chrisdennis commented 2 years ago

considering the EE kit is just this kit with some more plugins

That's not really true any more... but I agree that if the platform kit is working it's highly likely the EE one will too.

mathieucarbou commented 2 years ago

considering the EE kit is just this kit with some more plugins

That's not really true any more... but I agree that if the platform kit is working it's highly likely the EE one will too.

Before the PR I've looked at the jars of the EE kit and only the ones coming from platform were wrong

chrisdennis commented 2 years ago

It's true that we use the platform JARs... but we pull them as dependencies... we don't extract them from the kit.