search

Terracotta-OSS / terracotta-platform

http://terracotta.org
Apache License 2.0
32 stars 48 forks source link

Fix MultiDiagnosticServiceProvider which was incorrectly throwing exceeption and implementing the needed APIs #1144

Closed mathieucarbou closed 1 year ago

mathieucarbou commented 1 year ago

@mobasherul : please look at my latest changes here: https://github.com/Terracotta-OSS/terracotta-platform/compare/0ce655c11ae9ea5152d295e8726eed4562be1b93..3e964db3f6809998d01c4b33e6dac2ff381b660d

Test were failing because of this: https://github.com/Terracotta-OSS/terracotta-platform/compare/0ce655c11ae9ea5152d295e8726eed4562be1b93..3e964db3f6809998d01c4b33e6dac2ff381b660d#diff-fd2d62ddaa2a6b2a659c9ff9f46f05dbc66265e3ded1a1868d1787ed7f7cf754L126-L127 : I was constructing the fetcher with the field connctionTimeout, not the user-overridden value connTimeout which can be set to null when callers want short timeouts