Code cleanup

[mathieucarbou]

• lambda simplifications
  • Comparator.comparing
  • removal of brackets for simple lambdas
• typos
• unused suppress warnings
• duplicated json keys
• Junit upgrade:
  • Assert => MatcherAssert
  • ExpectException => assertThrow
• code simplifications
  • (i.e. Objects.equals)
  • .toString() on Strings
  • useless overrides
• removal of explicit type arguments
• readability
  • isEmpty()
  • missingfinal keyword
  • buggy logger lines (missing parameters or too much)
  • avoid array creation for toArray() calls
  • unused imports
  • renamed template letters on generic methods hiding any class-level template letter
  • use of try-resource block when should

[mathieucarbou]

@chrisdennis : thanks a lot ;-) we'll do an update tomorrow.

[chrisdennis]

I don't really want to review all 400+ files again! Do you want me to just approve on the grounds that you've resolved everything I've found and call it good, or do you want to try and get an independent review?

[mathieucarbou]

I don't really want to review all 400+ files again! Do you want me to just approve on the grounds that you've resolved everything I've found and call it good, or do you want to try and get an independent review?

You can just look at the latest diff on github if you want:

• https://github.com/Terracotta-OSS/terracotta-platform/compare/a411e0ebc3f29fadbdcfa893f8cd23befa8cd677..db0e49bc50f8d3359eabbe8a12aae7fe30a44d40
• https://github.com/Terracotta-OSS/terracotta-platform/compare/db0e49bc50f8d3359eabbe8a12aae7fe30a44d40..4ae9609bea1669200e7b4dd8654c83d1078c13ef

But I've helped the process by clicking on resolve for the things I am 100% sure about :-)

It's fine to merge it now.