search

Terracotta-OSS / terracotta-platform

http://terracotta.org
Apache License 2.0
32 stars 48 forks source link

M&M should handle inconsistent platform monitoring events #358

Closed mathieucarbou closed 7 years ago

mathieucarbou commented 7 years ago

if a user or a code error causes M&M to throw an exception, it should be sent or reported but should not crash the server.

=> review all throws from the monitoring service when voltron is calling us

CC @myronkscott @anthonydahanne @ljacomet @lorban : I'll let you add other details if needed, thanks 😃

mathieucarbou commented 7 years ago

@myronkscott : I will do the changes to handle the case where we have an inconsistent monitoring tree (we need to ignore everything coming from problematic clients or consumerId so tha twe can remove the throwing of illegal state exceptions).

On your side, would it be possible to still protect against runtime exception that are not recoverable that could occur in the IStripeMonitoring implementors, and log them, when you call these methods ?

Thanks!

UPDATE: I have opened https://github.com/Terracotta-OSS/terracotta-core/issues/692

mathieucarbou commented 7 years ago

@anthonydahanne : please follow this one also.