Cleanup: Huge XML cleanup

Terracotta-OSS / terracotta-platform

http://terracotta.org

Apache License 2.0

32 stars 48 forks source link

Cleanup: Huge XML cleanup #999

Open mathieucarbou opened 3 years ago

mathieucarbou commented 3 years ago

Moved all XML parsers to the converter (which was depending on them)
Stripped the XML parsers to their bare minimal requirement (which is outputting jaxb objects)
Removed any dependency towards tc-config-parser plus the descriptors
Removed any dependency towards tcconfig-schemas in plugins / services
Introduced a new interface XmlParser in DC api to replace the previous ones, and which is more focused on parsing jaxb objects

mathieucarbou commented 3 years ago

@chrisdennis : if this refactoring works for you, we can apply the same recipe for EE. The idea is to move the parser and jaxb objects to the converter EE module, and after that we can remove the dependency the converter had with the plugins / services. This centralizes all the ugly crap in one place.

The idea is to move out the XML code from the plugins / services to the converter tool, and then cleanup the dependencies of the converter tool.

Also, no need anymore to depend on tc-parser and the 2 interfaces. We can replace that easily with another one.

mathieucarbou commented 3 years ago

I'd much rather treat the old XML parsing code as legacy that we support.

=> the removed code was dead and was never called. We do not use the parse methods and old interfaces anymore (except when the jaxb objects were not directly accessible). Whether this is in this PR or before in DC... I have only kept the "jaxb" output.

mathieucarbou commented 3 years ago

will try to look at this one in some spare time...