search

Terraform-VMWare-Modules / terraform-vsphere-vm

Terraform vSphere module for provisioning Virtual Machines
https://registry.terraform.io/modules/Terraform-VMWare-Modules/vm/vsphere/
MIT License
169 stars 175 forks source link

add keep_on_remove param #162

Open dmpopoff opened 6 months ago

dmpopoff commented 6 months ago

manage keep or not template (OS) discs in case of VM destruction.

Arman-Keyoumarsi commented 5 months ago

Thanks for the PR. Please add the Smoke and Sanity test for review on both PR.

damnsam commented 5 months ago

My only comment on this is that there are two pull requests, keep_on_remove for template disks (this pull request), and the other pull request from same contributor to allow keep_on_remove for additional disks. Could there be a confusion on both if the variable name is the same in both places? This pull request would use a "list" type variable while the other PR is a boolean type variable. Functionally both can work and coincide, but I wonder if this one should use a different variable name like "keep_template_disks_on_remove", or something that makes more sense