search

TerraformersMC / Campanion

A camping companion mod that adds items and utilities to improve your life away from home
GNU Lesser General Public License v3.0
81 stars 31 forks source link

Fix some block entities not rendering in tent preview #168

Closed jhbuchanan45 closed 2 years ago

jhbuchanan45 commented 2 years ago

Block ID required in the nbt. Our block entity toTag() implementation mistakenly did this when the ID should only be added when the createNbtWithId() method is called.

Partially closes #167 I have also extensively looked into the grass blocks not rendering. It turns out any block rendered on the CUTOUT_MIPPED layer has this issue, and it has to do with our TentPreviewBufferBuilder vertex method multiplying the alpha value. I have no idea why this matters, someone more knowledgeable in shaders and minecraft rendering may know.

Wyn-Price commented 2 years ago

I noticed that normal CUTOUT does work, while CUTOUT_MIPPED does not. I plan to dive into the shader code after work today

Wyn-Price commented 2 years ago

A PR fixing cutout_mipped can be found here #169, once you remove that mixin, I'll merge and push a change to curseforge. Thanks for the help!

jhbuchanan45 commented 2 years ago

A PR fixing cutout_mipped can be found here #169, once you remove that mixin, I'll merge and push a change to curseforge. Thanks for the help!

Great, this PR should be ready now