search

TerraformersMC / ModMenu

A menu for, you guessed it, mods!
MIT License
486 stars 148 forks source link

Port 1.19.2 to 22w43a fixing #494 #496

Closed Bawnorton closed 1 year ago

Bawnorton commented 1 year ago

Modify ButtonWidget constructors to match new ButtonWidget constructor or implement builder Replace ClickableWidge#x/y with ClickableWidget#getX/Y() and ClickableWidget#setX/Y() Replace net.minecraft.util.math.Matrix4f with org.joml.Matrix4f;

ghost commented 1 year ago

I tried that version, but in-game there is no Mods button. Only from main menu.

Bawnorton commented 1 year ago

I missed it before but Mojang changed the game menu to include a grid that wraps the buttons. It works as expected now.

jackassmc commented 1 year ago

Looks good, thank you! Please test with the latest snapshot and add it to the supported Modrinth versions if it works.

jackassmc commented 1 year ago

@haykam821 could you test this on the latest snapshot? I'm on mobile at the moment.

jackassmc commented 1 year ago

Looks good, thank you! Please test with the latest snapshot and add it to the supported Modrinth versions if it works.

@haykam821 could you test this on the latest snapshot? I'm on mobile at the moment.

Nevermind, I'll merge and release this and test the latest snapshot later.

Thanks @Benjamin-Norton for the PR and @unit-a-user for the bug report!

haykam821 commented 1 year ago

Sorry for the delay. This version does work on Minecraft snapshot 22w44a.

image
jackassmc commented 1 year ago

No problem! Thanks for checking!