TerraformersMC / ModMenu

A menu for, you guessed it, mods!
MIT License
509 stars 157 forks source link

Config button not showing on some mods #509

Open BruhLmao-bot opened 2 years ago

BruhLmao-bot commented 2 years ago

So i've recently installed some mods to make the game look like older versions and its all worked fine till i wanted to configure the mods to enable stuff like instant food eating and the configuration button for all other mods aside from mod menu itself and minecraft. I havent seen any other people have this issue and i have the installation for 1.18.2 which is my current version 2022-11-25_07 54 22

TheSpiderDungeon commented 2 years ago

I have also been having this issue. A huge chunk of mods that I know have a config button just magically don't have one on the latest (4.1.1) version of Mod Menu. Some mod configs are (likely unintentionally) set up in such a way that they're horribly obnoxious without Mod Menu, which doesn't want to work :(

haykam821 commented 2 years ago

Are there any errors in the log?

TheSpiderDungeon commented 1 year ago

None at all that I could see. Maybe I didn't look in the right place in it?

jackassmc commented 1 year ago

@BruhLmao-bot I can't reproduce this with Minecraft 1.18.2 and Hunger Remover 1.0.3. Is this still happening? If so please post a full log.

@TheSpiderDungeon could you please share what mods are affected and post a full log?

ghost commented 1 year ago

Same as TheSpiderDungeon, mods I've previously seen a config button for have disappeared. Not all at once, they just disappeared overtime. Fixes I've tried include:

-Redownloading all mods and their latest versions + Fabric loader -Deleting the config folder entirely to reset configs (It just creates a new one upon launching Minecraft, but problem persists) -One by one, removing mods to see if it would restore other config buttons because of some sort of incompatibility idk

Prospector commented 1 year ago

Can anyone provide a simple case where I can reproduce this happening? Ideally just one mod that is supposed to have a config button but does not with just that mod and Mod Menu installed.

BeggarJr commented 1 year ago

Can anyone provide a simple case where I can reproduce this happening? Ideally just one mod that is supposed to have a config button but does not with just that mod and Mod Menu installed.

I am using Zoomift and Mod menu for 1.19.2. Zoomify should have an options menu, but does not have one Edit: typing "/zoomify" into chat should open the same settings menu, but it just crashes the game. I think this is an issue for zoomify or me, not mod menu

Felix14-v2 commented 1 year ago

I am using Zoomift and Mod menu for 1.19.2. Zoomify should have an options menu, but does not have one

Do you have YACL installed? This mod, like many others, requires an additional library for configuration.

@BruhLmao-bot , have you tried with Cloth-Config installed? Hunger Remover requires this library.

ghost commented 1 year ago

Can anyone provide a simple case where I can reproduce this happening? Ideally just one mod that is supposed to have a config button but does not with just that mod and Mod Menu installed.

It seems completely random which configs decide to disappear. I cant notice a pattern to it nor which mods it might happen with. I know that falling leaves' config button went away a while back and now it's reappeared. I don't know how long it's been back or if something caused it to reappear. It's difficult to pin down which configs go away and come back since it happens over time and I don't configure mods very often.

ghost commented 1 year ago

I am using Zoomify and Mod menu for 1.19.2. Zoomify should have an options menu, but does not have one

Do you have YACL installed? This mod, like many others, requires an additional library for configuration.

@BruhLmao-bot , have you tried with Cloth-Config installed? Hunger Remover requires this library.

Just to weigh in on this: When I was trying to figure out a fix (stated in an earlier post), I made sure I had all library mods required for all my mods (I did) and I tried removing the library mods one by one to see if it would restore the config button for other mods that didn't require it to see if it was causing some incompatibility or overwriting code. Unfortunately that didn't yield any results.

It really seems like this is a unique issue affecting a small percentage of us and to troubleshoot the cause you would have to know what the small percentage have in common. My guess is some code has been overwritten or modified (maybe by something the small percentage have all installed at one point) and Mod Menu can't find where the configs are. My earlier tests where I started from scratch with the config folder and mods installed must have had some residual code if such is the case.

BeggarJr commented 1 year ago

@Felix14-v2 Yes I do have YACL installed (YetAnotherConfigLib-2.2.0-for-1.19.2) Everything else is also appropriate version for 1.19.2, and i am playing on 1.19.2

Error code after typing "/zoomify" command in chat: The game crashed whilst unexpected error Error: java.lang.IncompatibleClassChangeError: Found interface dev.isxander.yacl.api.YetAnotherConfigLib$Builder, but class was expected

Felix14-v2 commented 1 year ago

The game crashed whilst unexpected error Error: java.lang.IncompatibleClassChangeError: Found interface dev.isxander.yacl.api.YetAnotherConfigLib$Builder, but class was expected

You should try an older version of YACL, Xander has made some code-breaking changes in it.

BeggarJr commented 1 year ago

@Felix14-v2 Yeah i just moved to 1.19.3 and it works now. I wanted to have on 1.19.2 for some mods but not worth the hassle

ghost commented 1 year ago

READ FOR POTENTIAL FIX

(This method might fix your problem, but sorry if I get your hopes up and it doesn't work.)

Alas, my journey has come to an end. I've just updated to 1.19.3 and this issue is entirely fixed for me. I've been holding off on updating as I have been waiting for the mods that I play with to finally make the transition to 1.19.3. Unfortunately not all of them have been updated, although, it's been too long that I've decided to cut them loose.

Upon loading into 1.19.3, all my configs have retuned. Now, if you've read my past comments, you'll know that I've tried some extensive testing where I've removed mods one by one to see if configs were disappearing because of some incompatibility and I still think this is the root of the issue. The difference here, updating to 1.19.3, is that I did a clean install of the newest Fabric mod loader for 1.19.3 and the newest versions of all my mods, except the ones that weren't updated; that I cut loose.

The API's & Libraries that I didn't keep are as listed: -Cloth Config API (Fabric) -Forge Config API Port -Indium -YetAnotherConfigLib -Puzzles Lib -Complete Config

The mods that I didn't keep are as listed: -Auditory -Easy Magic -Visual Workbench -Auto Third Person -Enhanced Block Entities -Extra Sounds

I believe one or more of these is the culprit preventing some configs from showing up. More likely an API or Library rather than a mod. If you never had any of these mods installed then idk :/ but here's what you can do to try to fix the problem and match what I did:

  1. Remove all mods from your mods folder for a fresh start.

  2. Download a clean install of the Fabric mod loader for a new version of Minecraft that hasn't previously had Fabric installed. A new Minecraft version might not be necessary, but it's the safest bet to match every factor that got it working for me. (It might have something to do with residual code that carries over to a new fabric version, as you're essentially updating Fabric, rather than doing clean install on a new version if you don't do it this way)

  3. Redownload all your mods' newest versions except the ones that I listed above if they were ever present.

  4. See if it works. At this point you should have a new fabric install on a new Minecraft version, latest versions of your mods (not the ones listed above), and configs should be accessible and just how you left them.

Even though the problem is fixed for me, I'm still invested in this thread and want to see if this is actually the fix, or if I'm associating the wrong cause to the effect. If you try this method, whether it works or not, please update all of us on exactly what you did and what circumstances might have changed the outcome. The mods I listed just happened to be the ones I cut loose but I guarantee that only a few or even just one mod is the culprit, inserting or overwriting code where other mods rely on for configuration. If we find that this method works, the next step would be determining just which mod is the cause through process of elimination.

Thanks <3

Prospector commented 1 year ago

Version v4.2.0-beta.1 of Mod Menu backports the 1.19.3 version entirely to 1.19.2. Would be great if anyone could see if this resolves the issue on 1.19.2: https://modrinth.com/mod/modmenu/version/4.2.0-beta.1

0username2bf commented 1 year ago

Version v4.2.0-beta.1 of Mod Menu backports the 1.19.3 version entirely to 1.19.2. Would be great if anyone could see if this resolves the issue on 1.19.2: https://modrinth.com/mod/modmenu/version/4.2.0-beta.1

I can unfortunately confirm that not even beta.2 has fixed this issue yet. For example, Camera Utils has no configuration button despite having one before.

Prospector commented 1 year ago

Looking at that mod's code, I don't see any evidence of it supporting Mod Menu

0username2bf commented 1 year ago

I am so sorry for wasting your time, very stupid mistake on my part--this is not the mod I had been using in the past, it was actually Shoulder Surfing Reloaded, which I have not tried on newer versions yet.

Prospector commented 1 year ago

Just checked out that mod's code too, I also don't see any Mod Menu support in there or in the config library that mod uses. Perhaps they removed it?

Prospector commented 1 year ago

Actually, maybe the mod Configured is supposed to do it. Possibly it is broken

Prospector commented 1 year ago

Ok I figured it out. It works if you install the mod "Configured" https://www.curseforge.com/minecraft/mc-mods/configured-fabric

The config API that the shoulder surfing mod uses silently requires this mod in order to have in-game configs.

image