search

TerraformersMC / ModMenu

A menu for, you guessed it, mods!
MIT License
484 stars 148 forks source link

ModMenu thinks v2.6.10 on Modrinth is newer than v2.6.11 (Also on Modrinth) #550

Closed Andre601 closed 1 year ago

Andre601 commented 1 year ago

ModMenu's update check doesn't seem to be that good or accurate as it tells me that the mod "Fast Load" has a new update available on Modrinth. The update in question is v2.6.10 (Or v1.19.3.fabric.2.6.10 as it is shown), which obviosuly isn't newer than 2.6.11 which is installed.

I think ModMenu thinks it's newer because the latest version for the loader (Fabric) is set to 2.6.11, while the previous version is set as 1.19.3.fabric.2.6.10.

Idk if there would be a fix for this, but perhaps a tool like FlexVer should be used for comparing versions, as it usually is capable of recognizing different version patterns like the above and properly determine if the version is actually new or not.

Screenshot: grafik

Prospector commented 1 year ago

Ah, yeah. You're running Quilt and the latest version on Modrinth available for Quilt is 2.6.10. Hmm...

Andre601 commented 1 year ago

Ah, yeah. You're running Quilt and the latest version on Modrinth available for Quilt is 2.6.10. Hmm...

Yeah... Idk, it's a bit weird for me. It should still prioritize the version tho imo, even if latest version is only fabric and not quilt.

Prospector commented 1 year ago

Going to say this is an issue on Modrinth's end: https://github.com/modrinth/labrinth/issues/545

Andre601 commented 1 year ago

Makes sense. I'll close this issue and hope this can be resolved on Modrinth's end.