TerraformersMC / ModMenu

A menu for, you guessed it, mods!
MIT License
476 stars 140 forks source link

Fix clicking on a configurable parent mod instantly opening its config #611

Closed LostLuma closed 1 year ago

LostLuma commented 1 year ago

Fixes #596 by only setting the sinceLastClick value once.

Since the two double click actions modmenu provides interfere with each other I've also made them exclusive of each other depending on whether quick configure is enabled, but maybe another solution should be thought of:

enabled -> double click on parent mod opens config, little arrow expand child mods disabled -> double click on parent mod expands child mods (nothing changed here)

Prospector commented 1 year ago

I think the way I originally intended for it to work was quick configure just wouldn't work for parents, but maybe this is a more expected way for it to work? idk.

LostLuma commented 1 year ago

I've asked one of my friends and this was her opinion, but yeah I was not sure 🙂

LostLuma commented 1 year ago

I'd expect that most times only the parent mod is really interesting to the user though (and the only one with a config) since mod modules are mostly an internal developer thing.

Prospector commented 1 year ago

True, I think this is good then. Thanks!