TerraformersMC / ModMenu

A menu for, you guessed it, mods!
MIT License
509 stars 157 forks source link

Mod website/issues buttons should not show red warning text #618

Open vrad-exe opened 1 year ago

vrad-exe commented 1 year ago

When clicking the website and issues buttons for a mod, the link confirmation shows the "Never open links from people you don't trust!" warning used for links placed in chat and the like. Given that installing a mod in the first place already requires putting a large amount of trust in the author, this seems rather meaningless. There's another version of the link confirmation without the red text (used for non-user provided links like the bugs/feedback buttons) which should probably be used instead. image

haykam821 commented 1 year ago

Note that the fix to this issue is to change the linkTrusted argument in the ConfirmLinkScreen constructor to true:

https://github.com/TerraformersMC/ModMenu/blob/0b88e0a67764d43c132859bc0ef0b3a9047d925c/src/main/java/com/terraformersmc/modmenu/gui/widget/DescriptionListWidget.java#L326-L331