TerraformersMC / ModMenu

A menu for, you guessed it, mods!
MIT License
476 stars 140 forks source link

ModMenu instantiates all mod's settings screens when opening the mod menu #622

Open Sollace opened 1 year ago

Sollace commented 1 year ago

Since mod menu is unneccessarily creating all these screens, besides impacting performance, if any of these mods' screens have an error it could cause a crash whilst trying to open the mod menu screen.

In my particular case, due to an inompatibility between Sodium and HDSkins, there's a crash that occurs when trying to create the dummy world the gui uses, and I was pulling my hair out trying to figure out why it was crashing from Mod Menu when, by all reason it should not even be reaching that point in the code.

My debugging led to this weird spot in Mod Menu's code: image