TerraformersMC / ModMenu

A menu for, you guessed it, mods!
MIT License
476 stars 140 forks source link

An error is generated when a mod does not have a logo.png #668

Open Jim3535 opened 8 months ago

Jim3535 commented 8 months ago

The mod handles loading a default icon when one isn't present, but it generates errors in the log file. It would be nice if it was an exception that could be caught or something checked before it gets to the stage where it generates the error.


java.lang.IllegalStateException: Must be square icon
    at org.apache.commons.lang3.Validate.validState(Validate.java:816) ~[commons-lang3-3.12.0.jar:?]
    at com.terraformersmc.modmenu.util.mod.fabric.FabricIconHandler.createIcon(FabricIconHandler.java:36) ~[modmenu-7.2.2.jar:?]
    at com.terraformersmc.modmenu.util.mod.fabric.FabricMod.getIcon(FabricMod.java:161) ~[modmenu-7.2.2.jar:?]
    at com.terraformersmc.modmenu.gui.widget.entries.ModListEntry.getIconTexture(ModListEntry.java:130) ~[modmenu-7.2.2.jar:?]
    at com.terraformersmc.modmenu.gui.widget.entries.ModListEntry.method_25343(ModListEntry.java:59) ~[modmenu-7.2.2.jar:?]
    at com.terraformersmc.modmenu.gui.widget.ModListWidget.method_25311(ModListWidget.java:241) ~[modmenu-7.2.2.jar:?]
    at net.minecraft.class_350.method_25394(class_350.java:227) ~[client-intermediary.jar:?]
    at com.terraformersmc.modmenu.gui.ModsScreen.method_25394(ModsScreen.java:285) ~[modmenu-7.2.2.jar:?]
    at net.minecraft.class_437.method_47413(class_437.java:110) ~[client-intermediary.jar:?]
    at net.minecraft.class_757.method_3192(class_757.java:945) ~[client-intermediary.jar:?]
    at net.minecraft.class_310.method_1523(class_310.java:1219) ~[client-intermediary.jar:?]
    at net.minecraft.class_310.method_1514(class_310.java:802) ~[client-intermediary.jar:?]
    at net.minecraft.client.main.Main.main(Main.java:250) ~[minecraft-1.20.1-client.jar:?]
    at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468) ~[fabric-loader-0.14.22.jar:?]
    at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) ~[fabric-loader-0.14.22.jar:?]
    at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) ~[fabric-loader-0.14.22.jar:?]
    at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88) ~[NewLaunch.jar:?]
    at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126) ~[NewLaunch.jar:?]
    at org.prismlauncher.EntryPoint.main(EntryPoint.java:71) ~[NewLaunch.jar:?]
[20:54:08] [Render thread/WARN]: Warning! Mod villagerarmor has a broken icon, loading default icon```