search

TerraformersMC / ModMenu

A menu for, you guessed it, mods!
MIT License
509 stars 157 forks source link

Author order is not preserved in the credits list #725

Open haykam821 opened 6 months ago

haykam821 commented 6 months ago

As of #706, credits for Fabric mods now separate by authors and contributors, with each list being sorted alphabetically.

However, authors are often listed in a particular order, meaning that the primary author of a mod may be sorted after its secondary authors. This behavior is also inconsistent with the order shown in the authors list next to the icon.

To keep the intent of the authors list, I believe that authors should not be sorted within the credits.

LostLuma commented 6 months ago

I don't think that the author or contributor order is actually guaranteed to be equal to the order in the json file on either Fabric or Quilt. I reverted the last two commits on the PR and looked at a mod with a lot of contributors in ModMenu and the contributors are in random order, even though in the source file they are sorted alphanumerically. (Same situation on Quilt, obviously.)

Prospector commented 6 months ago

Hmm, weird. I think this must be a recent change or possibly just something that happens outside of dev? I always observed it being in the json order, as I sort authors by seniority and contributors in chronological order

LostLuma commented 6 months ago

I realized my testing was flawed because I inserted the list of names into a collection that doesn't preserve order.