search

TerraformersMC / Terraform

Base library for the Terraformers' mods
GNU Lesser General Public License v3.0
37 stars 16 forks source link

MixinTreeFeature must look below the feature to see soil type. #54

Closed gniftygnome closed 2 years ago

gniftygnome commented 2 years ago

MixinTreeFeature cannot allowSandyTreeGeneration because it checks for sand in the base of the tree, not below. Adding .down() as below resolves this problem.

        if ((this instanceof ExtendedTreeGeneration)) {
            return ((ExtendedTreeGeneration) this).canGenerateOn(world2, pos.down());
NebelNidas commented 2 years ago

Perfect, thank you! Baffling how I haven't caught this before 👍

haykam821 commented 2 years ago

Will this fix be merged into the 1.17 branch? I have no personal interest in maintaining branches other than the release and snapshot branches but an exception can be made for this one issue.

gniftygnome commented 2 years ago

Will this fix be merged into the 1.17 branch?

I hope so ... I wanted to get to where I could treat the 1.17 PR of Terrestria as "good" because it gives a better starting point for doing work on 1.18.2. (Even though this entire mechanic has been removed in Terraform for 1.18 ... figuring out what to do about that is coming up soon.)

NebelNidas commented 2 years ago

Will this fix be merged into the 1.17 branch?

I'm completely on your side, but since my 1.17 Terrestria PR is completely finished aside from this one bug, I'd really like to get this one merged in so I can finally release the 1.17 version :)

NebelNidas commented 2 years ago

Thanks! 👍