search

TerraformersMC / Terraform

Base library for the Terraformers' mods
GNU Lesser General Public License v3.0
37 stars 16 forks source link

Pre-launch entrypoint to initialize MixinExtras is unnecessary #76

Closed haykam821 closed 1 year ago

haykam821 commented 1 year ago

Since the bundled version of MixinExtras that initializes on its own should be used, the pre-launch entrypoint that calls MixinExtrasBootstrap.init() is not needed.

gniftygnome commented 1 year ago

Are you saying the MixinExtras usage instructions are incorrect? The MixinExtras documentation is unambiguous about this: https://github.com/LlamaLad7/MixinExtras#initialization

gniftygnome commented 1 year ago

I poked around in the source for 0.2.0-beta.5 a bit and nothing jumps out to me as triggering registration on its own. I think without the init() call the game will run and appear to work but the MixinExtras mixins will not be applied, so unless you have tested that specific functionality it might be hard to tell anything is wrong.

haykam821 commented 1 year ago

The new documentation indicates that calling MixinExtrasBootstrap.init() isn't necessary, since it's called here.

gniftygnome commented 1 year ago

I see ... apparently I should have paid more attention to what the upgrade from 0.2.0-beta.4 to 0.2.0-beta.5 entailed. I had not intended to increase our minimum Fabric Loader version in 1.19. :(

gniftygnome commented 1 year ago

Resolved in 7.0.0-beta.1.