search

TerraformersMC / Terraform

Base library for the Terraformers' mods
GNU Lesser General Public License v3.0
37 stars 16 forks source link

wood-api sign crash (Natures Spirit) #81

Closed sleepy-evelyn closed 12 months ago

sleepy-evelyn commented 12 months ago

The wood api causes a crash when using Natures Spirit. I'm not entirely sure which end needs to be fixed yet but I'll show you where it happens, why, the log and versions.

Quilt Loader: 0.21.1-beta2 MC Version: 1.20.1 Natures Spirit version: 1.1 Wood api version: wood-api-v1-7.0.1 (jar-in-jar dependency from Blockus) Crash Log: https://bytebin.lucko.me/1D2N7EE9sA

To Reproduce: Place any Natures Spirit sign down

Location of the crash: https://github.com/TerraformersMC/Terraform/blob/7783a401d60b2b1bb8398207bb97018a5f3e86b6/terraform-wood-api-v1/src/main/java/com/terraformersmc/terraform/sign/mixin/MixinSignBlockEntityRenderer.java#L33

sleepy-evelyn commented 12 months ago

Never mind I removed all the wood-api mods and I still have the issue. It's bizarre.

haykam821 commented 12 months ago

I think Terraform Wood API v1's mixin obfuscates the actual error, which is that a mod is not registering their sign to the TexturedRenderLayers.SIGN_TYPE_TEXTURES map causing the sprite identifier to be null. In theory, signs registered with this API should never have a null sprite identifier as long as the trick used to get the block entity as context is not affected by another mixin.

Eko-byte commented 11 months ago

oh wait, this helps thank you