search

TerraformersMC / Terraform

Base library for the Terraformers' mods
GNU Lesser General Public License v3.0
37 stars 16 forks source link

Registers a new TrackedDataHandler #87

Open TropheusJ opened 9 months ago

TropheusJ commented 9 months ago

A new TrackedDataHandler is registered and used to track boat types here.

This is extremely unsafe and makes the mod prone to load-order dependent issues that are impossible to debug.

Instead, a plain field and manual syncing with a custom packet should be used.

gniftygnome commented 9 months ago

Out of curiosity, what load order issue have you discovered?

haykam821 commented 9 months ago

There's a more technical explanation at FabricMC/fabric#3482.

gniftygnome commented 9 months ago

Ohh, all yours then. :)

haykam821 commented 9 months ago

I believe Brandcraf06/Blockus#322 is also caused by this issue as that mod uses this library.

If necessary, I think we will be able to use the vanilla optional integer tracked data handler instead of a custom one. The only drawback would be needing to convert (and validate) data within the entity which is a slightly less neat split between logic and networking.