search

TerraformersMC / Terrestria

A Fabric mod enhancing the detail of Minecraft with unique and vibrant biomes. Inspired by ExtrabiomesXL.
https://www.curseforge.com/minecraft/mc-mods/terrestria
GNU Lesser General Public License v3.0
201 stars 43 forks source link

Add common tags to basalt blocks #117

Closed Sturmlilie closed 4 years ago

Sturmlilie commented 4 years ago

For compatibility with TechReborn; see https://github.com/TechReborn/TechReborn/pull/2091

Prospector commented 4 years ago

I guess the one thing that makes this tricky is that in 1.16 we renamed basalt to Volcanic Rock to not conflict with vanilla's basalt. Not sure what exactly we should do here

Sturmlilie commented 4 years ago

Hmm you're right, people will not get the connection that your volcanic rock grinds into basalt dust. At the same time vanilla is soon going to have more basalt than anyone can carry, with the caveat that it's only available via the nether. Then again, anyone with REI installed can instantly find out what grinds into basalt dust.

coderbot16 commented 4 years ago

I think it would will be reasonable to treat volcanic rock like basalt even after the name change.

coderbot16 commented 4 years ago

It might still make sense to have Volcanic Rock grind into Basalt Dust still.

coderbot16 commented 4 years ago

Uh, please disregard the above mess. I think this change makes sense, but it should probably be targeted on 1.16

NeusFear commented 4 years ago

@Sturmlilie would you mind updating this PR to 1.16, if not I'll go ahead and close the PR

Sturmlilie commented 4 years ago

Tested with latest Tech Reborn for 1.16.1.

Sturmlilie commented 4 years ago

Just a heads up, there are problems with tags on latest MC versions. See: https://github.com/TechReborn/RebornCore/issues/159

NeusFear commented 4 years ago

@Sturmlilie is this just the in-dev issue?

Sturmlilie commented 4 years ago

@NeusFear not sure what "in-dev" refers to; we've had multiple people hop on the TechReborn discord and report their Blockus compat being broken. It means that even if this PR gets merged, until the tag issue gets fixed, Terrestria basalt will presumably not be grindable in TR.

NeusFear commented 4 years ago

in-dev means when launching the game from the development environment as opposed to using a built jar as a mod to the obfuscated game.

NeusFear commented 4 years ago

I think it should be fine

Sturmlilie commented 4 years ago

in-dev means when launching the game from the development environment as opposed to using a built jar as a mod to the obfuscated game.

I pretty much never use this loom feature.