coderbot16 commented 3 years ago

This PR mirrors some banners from Imgur / Gyazo into the repository. It also mirrors the README from CurseForge, leaving it in raw HTML format.

Rationale

Hosting sites like Imgur and Gyazo have little incentive to continue hosting our images far into the future. For examples of where this has happened before, see TinyPic, or go to the ExtrabiomesXL Wiki and count all of the broken or tampered-with images.
However, checking the images into Git ensures that they are adequately archived and will always be accessible to anyone who has a copy of the repository, and without an internet connection.
While GitHub proxies image requests to prevent tracking, other sites like CurseForge do not. Therefore, each person who views our images can be potentially fingerprinted and/or tracked by Imgur.

Downsides

This increases the size of the repository by quite a bit. taking it from about 7 MB to around 10 MB. However, this increase isn't too significant in the grand scheme of things.

coderbot16 commented 3 years ago

That is an option, however I chose to store the images in the mod repo for a few reasons:

Storing them on the mod repo allows the README links to be relative, meaning that they'll work just fine with cloned repos (without actually needing to fetch the image from the internet).
Only one of these images (the Terrestria banner) is actually used by both the wiki repo and the mod repo. I think it makes more sense to store the images in the repositories where they are used.
While having them on the mod repo increases its size, the size increase is not substantial, and only has an impact when someone needs to re-clone the entire repository. Though our CI currently does this, it's probably possible for it to do a more simple git pull each time too.

coderbot16 commented 3 years ago

Great, thanks!