TerraformersMC / Terrestria

A Fabric mod enhancing the detail of Minecraft with unique and vibrant biomes. Inspired by ExtrabiomesXL.
https://www.curseforge.com/minecraft/mc-mods/terrestria
GNU Lesser General Public License v3.0
199 stars 43 forks source link

Include Fabric API inside Terrestria, so that it doesn't need to be downloaded separately. #217

Closed coderbot16 closed 3 years ago

coderbot16 commented 3 years ago

This hopefully streamlines the installation process, because it's one less step that the user could forget.

I imagine that there's at least a small percentage of people who just download Terrestria, forget fabric API, don't understand the resulting unintuitive crash ("but I already installed fabric, why is it asking me to install it again?"), then ditch Terrestria because they can't get it working.

From what I've seen, this appears to be the preferred approach (compared to just making the user download fabric api) based on things like https://github.com/FabricMC/fabric-loom/pull/183 and https://github.com/FabricMC/fabric-installer/pull/38#pullrequestreview-417087209 (specifically, the "Those that do should not need to worry about installing it" part).

This PR also drops the dependency on LibStructure, because it effectively got ported into Fabric API in the form of fabric-structure-api-v1. This means that we have one less maven server to depend on, and don't need to worry about whether the library will be updated for future Minecraft versions.