search

TerraformersMC / Terrestria

A Fabric mod enhancing the detail of Minecraft with unique and vibrant biomes. Inspired by ExtrabiomesXL.
https://www.curseforge.com/minecraft/mc-mods/terrestria
GNU Lesser General Public License v3.0
199 stars 43 forks source link

Crash when Waterlogging Sakrua Tree Logs and Leaf Piles #232

Closed emoace closed 3 years ago

emoace commented 3 years ago

This has also happened upon terrain generation, for instance if a Sakura Tree generated in a lake or something along those lines.

When waterlogging Leaf Piles, Not Enough Crashes says that Lithium is the culprit, but it seems the underlying problem is the same as when waterlogging the Sakura Tree Logs.

crash-2021-01-21_22.35.22-server.txt

crash-2021-01-21_22.33.08-client.txt

crash-2021-01-20_23.54.02-server.txt

coderbot16 commented 3 years ago

That looks bad. Does this happen with just Terrestria installed? I noticed that you have a lot of mods installed in those crash reports.

I saw this specific crash a few months back but it was never reported (and I couldn't figure out how to reproduce it), so thanks for reporting this!

emoace commented 3 years ago

You're welcome! Glad I could help!

I created a new instance with only Terrestria, Traverse, Cinderscapes, REI, Fabric API, and Lithium.

I was able to waterlog Sakura Logs no problem even with Lithium on. As for the Leaf Piles, the water was just placed above the pile and disappeared like tall grass shortly after. This is as shown in the pics provided.

2021-01-22_15 19 39 2021-01-22_15 15 44

However, once I added Canvas, Hydrogen, Phosphor, Overworld 2, and Not Enough Crashes, the same crash occurred again: crash-2021-01-22_15.30.08-client.txt

I couldn't waterlog the Leaf Pile even with more of the mods installed, but I could place a Sakura Log in an existing block of water, but when I placed another log connecting to the Sakura Log, the game crashed: 2021-01-22_15 35 03 2021-01-22_15 35 15 crash-2021-01-22_15.35.08-server.txt

After I removed Hydrogen, the problem did not occur as shown in this photo: 2021-01-22_15 42 06

I even tried it with the bigger pack, removing Hydrogen, and the issue was resolved.

So I would say it is an incompatibility with JellySquid's Hydrogen Mod, at least on my end. I will let you know if this occurs again without Hydrogen.

coderbot16 commented 3 years ago

Good to know. I will try reproducing it too.

coderbot16 commented 3 years ago

Seems to be related to https://github.com/jellysquid3/hydrogen-fabric/issues/10

coderbot16 commented 3 years ago

Based on my research in https://github.com/CaffeineMC/hydrogen-fabric/issues/19, this is because Terrestria / Terraform construct a BooleanProperty.of("waterlogged") and then use Properties.WATERLOGGED in place of it at times. Terrestria and Terraform should not do this. While this at the very least happens with waterlogged things, I want to go through the code and ensure that there are no other instances of this kind of behavior. Preferably, if a "standard" property exists for something, we should just use that in all cases.