search

TerraformersMC / Terrestria

A Fabric mod enhancing the detail of Minecraft with unique and vibrant biomes. Inspired by ExtrabiomesXL.
https://www.curseforge.com/minecraft/mc-mods/terrestria
GNU Lesser General Public License v3.0
201 stars 43 forks source link

Missing Color Providers #252

Closed CoolMineman closed 2 years ago

CoolMineman commented 3 years ago

DARK_JAPANESE_MAPLE_LEAVES, JUNGLE_PALM_LEAVES, and maybe some other things are missing color providers. https://github.com/TerraformersMC/Terrestria/blob/1.16.3/src/main/java/com/terraformersmc/terrestria/TerrestriaClient.java#L51-L62 Causes CoolMineman/BitsAndChisels#26

coderbot16 commented 3 years ago

I suppose that it would be possible to register a default color provider here, since the colors for those leaves are baked into the texture.

But the Bits and Chisels code there is broken - you should be using the vanilla BlockColors class instead, since it's not guaranteed that all colored blocks will exist in Fabric's ColorProviderRegistry.

CoolMineman commented 3 years ago

Switched to BlockColors in B&C