Closed NebelNidas closed 1 year ago
Sounds great! Let me know if you need anything from me. Also feel free to message me on discord.
Leaves dropping themselves still has to be fixed, but otherwise, I think we're ready for an alpha release :)
It seems there's something wrong within TerrestriaConfiguredFeatures.registerSandyTree
, as all trees registered with this function don't work
This is a pretty quick review, but it does catch a few things. Did MC just like replace all of the TestableWorld classes with TestableWorld?
They did, yes. See here for example:
Everything looks good to me so far, once those remaining few issues are fixed. The sandy tree thing is just there to allow trees to grow on sand as well. Decaying leaves had this problem once before, but I don't remember the way it was fixed
The sandy tree thing is just there to allow trees to grow on sand as well.
I think the error is on the Terraform Tree API side of things, because the non-sandy trees register just fine and the only thing differing is this one line: https://github.com/TerraformersMC/Terrestria/pull/266/files#diff-2f5324fdf596fe154d0265b05ba1b3b0780853741c43decb44a05cb7838f74a2R227
Edit: Seems GitHub doesn't like linking to huge diff files; here's the line I meant: Compared to the one that works:
Is this still happening or no?
It's fully functional the way is, apart from the sandy trees not working (see my comment on the top) 🙂. @SuperCoder7979 wanted to take a look at this issue (he's much better at this stuff than me), but I think he didn't have time yet
The issue with sandy tree generation is pretty simple (I think). See https://github.com/TerraformersMC/Terraform/pull/54 which fixes the problem for me.
Terraform Tree API 2.0.1 has been released with this fix. All this PR needs now is just a bump to the Tree API version.
Perfect! Will do that in a few hours 👍
This is a continuation of #256, which has been abandoned apparently. I have bumped all remaining dependencies and rewritten all of the boat-related stuff to work with the new
terraform-wood-api-v1
2.0.x. I'll take a look your comments from the last PR tomorrow, @NeusFear; hopefully we can finally get this update done soon.Currently unresolved issues:
Decaying leaves drop themselves(fixed by 04b8b72e2cc882e77113217df34d7e7524b0ba62)- The following trees don't naturally generate and can't be grown manually either:Bryce TreeJungle PalmSaguaro CactusYucca Palm(should be fixed by https://github.com/TerraformersMC/Terraform/pull/54)