search

TerraformersMC / Terrestria

A Fabric mod enhancing the detail of Minecraft with unique and vibrant biomes. Inspired by ExtrabiomesXL.
https://www.curseforge.com/minecraft/mc-mods/terrestria
GNU Lesser General Public License v3.0
201 stars 43 forks source link

1.18.2 with biome mappings, without biome generation #270

Closed gniftygnome closed 2 years ago

gniftygnome commented 2 years ago

Alternative option in case it's useful: I've applied the things Prospector did when accepting the Traverse 1.18.2 PR.

Comments: I did not update Contributors (seems kind of maintainer-y plus maybe I don't know them all). My biome mappings should be reviewed. I might have picked the wrong targets and/or you might prefer other targets. Terrestria mega tree saplings do not grow in either of my PRs. I am not sure where to look but will poke at it more.

gniftygnome commented 2 years ago

I've tested this version converting from my other PR and also from an old 1.16.5 world. In both cases, things worked as expected. Minecraft gets kinda piggy when it's generating terrain at the edges of existing Terrestria chunks, but that's probably to be expected. Upgrading from 1.16.5 seamlessly converted Redwood Clearing and Redwood Forest Edge to Redwood Forest.

gniftygnome commented 2 years ago

Terrestria mega tree saplings do not grow in either of my PRs. I am not sure where to look but will poke at it more.

OK they actually grow just fine, but I was testing on snowy grass and the snow must be cleared around the saplings (4x4 snow clear area, not 2x2). This seems like a bug to me, but maybe not a new one?

Edit: Turns out vanilla mega growth works the same way, so I think this is a non-issue.

gniftygnome commented 2 years ago

This PR is superseded by #269, which does everything this does and more and safely in combination with Traverse.