search

TerraformersMC / Terrestria

A Fabric mod enhancing the detail of Minecraft with unique and vibrant biomes. Inspired by ExtrabiomesXL.
https://www.curseforge.com/minecraft/mc-mods/terrestria
GNU Lesser General Public License v3.0
199 stars 43 forks source link

[1.18.2-4.0.2] Rubber signs drop oak signs when broken #276

Closed Gronglegrowth closed 1 year ago

Gronglegrowth commented 1 year ago

Seems like their loot tables weren't setup correctly? I've not looked at the other signs but rubber at least is for sure affected by this.

Clarification: Only happens with signs placed on the side of blocks.

gniftygnome commented 1 year ago

Could you clarify what version of Terrestria this is about? Versions for Minecraft 1.18.2 should start with 4, not 1.

Gronglegrowth commented 1 year ago

It's 4.0.2, I must have been reading the version number of a different mod, apologies for that

gniftygnome commented 1 year ago

I just tested this with 4.0.2 and cannot reproduce. With bare hand or with axe, either on the wall or on the ground, rubber wood signs break and yield rubber wood signs. If you would like to provide the full logs I can look for something in there but I'm not certain what is going on otherwise.

Gronglegrowth commented 1 year ago

Here's a log wherein the only actions I took were giving myself a rubber wood sign, placing it, then breaking it, but at a glance it seems like nothing of note's in here. It must be caused by some other mod? The modpack I am using is here if you'd like to experiment with what might be happening.

gniftygnome commented 1 year ago

This appears to be a difference in behavior of Quilted Fabric API vs. actual Fabric API. I can reproduce this result when running via Quilt with only Terrestria installed. Being as Quilt aims to exactly reproduce Fabric APIs, I suspect this is a bug in Quilted Fabric API (especially since the loot tables in question are generated via Minecraft data generation). I may try and track it down and/or see if I can work around it if I manage to make time.

gniftygnome commented 1 year ago

This is finally resolved in the recent releases of our mods for 1.19 - 1.19.2, 1.19.4, and 1.20.x.