search

TerraformersMC / Terrestria

A Fabric mod enhancing the detail of Minecraft with unique and vibrant biomes. Inspired by ExtrabiomesXL.
https://www.curseforge.com/minecraft/mc-mods/terrestria
GNU Lesser General Public License v3.0
199 stars 43 forks source link

[Incompatibility] Immersive Weathering + Terrestria (leaf block) #279

Closed DemonMartin closed 9 months ago

DemonMartin commented 1 year ago

This randomly spammed my console when flying through my world

Some mod tried to call leaves random tick without passing a leaf block blockstate as expected. This should be fixed on their end. Given blockstate : Block{terrestria:redwood_leaves}[distance=3,persistent=false] 18:52:48.801 com.ordana.immersive_weathering.ImmersiveWeathering Render thread Some mod tried to call leaves random tick without passing a leaf block blockstate as expected. This should be fixed on their end. Given blockstate : Block{terrestria:redwood_leaves}[distance=2,persistent=false] 18:52:49.051 com.ordana.immersive_weathering.ImmersiveWeathering Render thread Some mod tried to call leaves random tick without passing a leaf block blockstate as expected. This should be fixed on their end. Given blockstate : Block{terrestria:redwood_leaves}[distance=2,persistent=false]

gniftygnome commented 1 year ago

Thank you for filing this; we had a report of something similar for the small trunk leaves, but this appears to indicate the issue may be more broad (possibly all Terrestria leaves). This issue may belong to Terraform lib rather than Terrestria but I won't have time to investigate for another few weeks, probably.

gniftygnome commented 9 months ago

Trinsdar mentioned:

Yah i already know the cause, immersive weathering logs every tick if the leaf found is not an instance of LeafBlock, which terrestria's are not, which causes the lag. Quite stupid piece of code imo, not even sure why that check is needed

I'm going to assume that is in fact the entire issue (logging something every tick is very, very slow). The good news is that since 6.1.0-alpha.1 (for Minecraft 1.19.4), Terraform API's ExtendedLeavesBlock does in fact extend LeavesBlock. I just forgot to close this issue.