search

TerraformersMC / Terrestria

A Fabric mod enhancing the detail of Minecraft with unique and vibrant biomes. Inspired by ExtrabiomesXL.
https://www.curseforge.com/minecraft/mc-mods/terrestria
GNU Lesser General Public License v3.0
198 stars 43 forks source link

Soft incompatibility with "tectonic" mod #328

Open radekr5 opened 2 months ago

radekr5 commented 2 months ago

Terrestria is interfering with creation of underground rivers from tectonic, making them look rough with strainght horisontal walls. ( Terrestria mod version 6.0.13 , tectonic version 2.2, on fabric 1.20.1 , 0.15.9)

gniftygnome commented 2 months ago

I didn't see any of this on the 1.20.4 versions of the mods. What makes you think Terrestria is causing it? At a guess, perhaps because you are seeing a Terrestria biome in debug when it happens? If so, what biome?

gniftygnome commented 2 months ago

I think I may have found an example. I'm guessing this is happening where there are Caldera biomes, so you could disable those in Terrestria's config. It could also happen with Canyon and Dunes. Basically whatever Tectonic is doing to add the rivers probably happens before Minecraft's surface builders execute, and Terrestria uses surface builders to modify the surface height in some biomes. There's not really anything Terrestria (actually, Biolith) can do differently here. The noise surface has to already be generated before surface builders can run.

This isn't the only "soft" incompatibility between the two mods. Tectonic modifies the depth of lukewarm oceans, which causes Terrestria's Volcanic Island biome to basically not generate (last I checked there isn't a good way to get the depth of ocean biomes from Minecraft).

gniftygnome commented 2 months ago

Yeah, Calderas generate pretty cursed in Tectonic worlds anyway. You'll be better off just disabling them.

Apollounknowndev commented 2 months ago

Basically whatever Tectonic is doing to add the rivers probably happens before Minecraft's surface builders execute

Yep, Tectonic handles underground rivers during terrain shaping which is before surface rules.

gniftygnome commented 2 months ago

I've thought about trying to move the surface builders earlier, because there are various downsides to using surface builders these days (particularly how Minecraft has already decided what Y level to place structures). However, I suspect there would be some other downsides to doing it earlier and I haven't gotten around to investigating those yet.

radekr5 commented 2 months ago

I didn't see any of this on the 1.20.4 versions of the mods. What makes you think Terrestria is causing it? At a guess, perhaps because you are seeing a Terrestria biome in debug when it happens? If so, what biome?

aa, im using 1.20.1 version, maybe that . and as for what biome was on top af a river, it was a redwood forest ( with 4 thick and tall as F%^& trees).

So basicly, if i want to report this bug, i need to type to tectonic team about it ?

radekr5 commented 2 months ago

Yeah, Calderas generate pretty cursed in Tectonic worlds anyway. You'll be better off just disabling them.

i can do that via config file?( or mod menu mod) or need to dig deeper ?

gniftygnome commented 2 months ago

So basicly, if i want to report this bug, i need to type to tectonic team about it ?

Apollo already commented here, and I doubt there's a way for Tectonic to make this work any easier than for me to.

i can do that via config file?( or mod menu mod) or need to dig deeper ?

The biome config file file for Terrestria will be in the config dir of of the server (usually at the top level next to mods and resourcepacks, in terrestria/biome.json. Just set "caldera": true to "caldera": false.

radekr5 commented 2 months ago

The biome config file file for Terrestria will be in the config dir of of the server (usually at the top level next to mods and resourcepacks, in terrestria/biome.json. Just set "caldera": true to "caldera": false.

okay, thanks for instructions , disabled caledras and volcanic island.