search

Terrails / colorful-hearts

A client side mod that replaces multiple vanilla heart rows with a single row using colored hearts
MIT License
6 stars 4 forks source link

loading ResourceLocation class early breaking mixins #17

Closed Linguardium closed 10 months ago

Linguardium commented 10 months ago

https://github.com/Terrails/colorful-hearts/blob/86ca32195a683cb83fe58cadf3a75d4eaf19388b/fabric/src/main/java/terrails/colorfulhearts/fabric/FabMixinPlugin.java#L25C22 Loading your Logger reference here

will class load your main class,

https://github.com/Terrails/colorful-hearts/blob/a5ffc190b480a88d2ff532fc666c5117ba43db2f/common/src/main/java/terrails/colorfulhearts/CColorfulHearts.java#L13 which then loads ResourceLocation to set the static field. dont do this.

Terrails commented 10 months ago

Should be fixed now. Fetching the logger inside the plugin instead of using a reference from the main class.