Variety of improvements

TerrainBento / terrainbento

A modular landscape evolution modeling package built on top of the Landlab Toolkit.

https://terrainbento.readthedocs.io/

MIT License

19 stars 8 forks source link

Variety of improvements #63

Closed kbarnhart closed 6 years ago

kbarnhart commented 6 years ago

Addresses #62

kbarnhart commented 6 years ago

A few notes:

1) @gregtucker I have made a small number of changes to the stochastic models.... Sorry if this causes you merge conflicts. Its mostly to get rid of stuff so you don't need to test it and to change the parameter names.

2) @Glader011235 after this PR is merged, you can start on making unit tests for the following models.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 427

129 of 138 (93.48%) changed or added relevant lines in 27 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+9.9%) to 82.939%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
terrainbento/derived_models/model_208_basicDdVs.py	7	8	87.5%
terrainbento/derived_models/model_202_basicThVs.py	5	6	83.33%
terrainbento/derived_models/model_100_basicSt.py	0	3	0.0%
terrainbento/derived_models/model_300_basicStVs.py	0	4	0.0%
<!--	Total:	129	138	93.48%	-->

Files with Coverage Reduction	New Missed Lines	%
terrainbento/derived_models/model_100_basicSt.py	1	25.0%
terrainbento/derived_models/model_300_basicStVs.py	2	23.08%
<!--	Total:	3	-->

Totals
Change from base Build 421:	9.9%
Covered Lines:	1507
Relevant Lines:	1817

💛 - Coveralls

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 427

129 of 138 (93.48%) changed or added relevant lines in 27 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+9.9%) to 82.939%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
terrainbento/derived_models/model_208_basicDdVs.py	7	8	87.5%
terrainbento/derived_models/model_202_basicThVs.py	5	6	83.33%
terrainbento/derived_models/model_100_basicSt.py	0	3	0.0%
terrainbento/derived_models/model_300_basicStVs.py	0	4	0.0%
<!--	Total:	129	138	93.48%	-->

Files with Coverage Reduction	New Missed Lines	%
terrainbento/derived_models/model_100_basicSt.py	1	25.0%
terrainbento/derived_models/model_300_basicStVs.py	2	23.08%
<!--	Total:	3	-->

Totals
Change from base Build 421:	9.9%
Covered Lines:	1507
Relevant Lines:	1817

💛 - Coveralls

kbarnhart commented 6 years ago

There are some file reading errors on Window 2.7. Other than that, this is OK. I'll assess those errors and fix.