search

TerrainBento / terrainbento

A modular landscape evolution modeling package built on top of the Landlab Toolkit.
https://terrainbento.readthedocs.io/
MIT License
19 stars 8 forks source link

vsa tests #65

Closed Glader011235 closed 6 years ago

Glader011235 commented 6 years ago

aiming for 100% no buggies

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 479

Totals Coverage Status
Change from base Build 432: 0.6%
Covered Lines: 1517
Relevant Lines: 1817
💛 - Coveralls
Glader011235 commented 6 years ago

Basic pure diffusion and pure stream power tests are good to go on models 200, 202, 208, 210- haven't written any VSA specific ones yet, and I held off on model 300 (StVs) yet because I'm not sure how to deal with the St part...

kbarnhart commented 6 years ago

@Glader011235 this is awesome!

Also, as a general note, the self.K vs self.K_sp error you fixed was a new thing that I induced in PR #63 (aka, not old and actually a problem). I tried to find all the places where that was a problem, bt because not everything had precipchanger tests, it was hard... Thank you for finding it!

not surprisingly, we still have 2 windows python 2.7 failures in AppVeyor. That is my fault and I will fix it.

kbarnhart commented 6 years ago

Few other thoughts on tests.

1) don't worry about 300 at the moment.

2) As best as I can tell, the most extensive steady state test that we can do when Aeff is different from A is as follows:

a) assert that Aeff has been calculated correctly

b) assert that slopes are all consistent with K Aeffm Sn

c) we could assert that all slopes are steeper than what we'd calculate with K Am Sn, but I don' think it would add anything to (a) and (b)

Glader011235 commented 6 years ago

Ok Katy, I think these are good to go!