search

Terrapin-Rocket-Team / Multi-Mission-Flight-Software

An arudino library used by the Terrapin Rocket Team as the foundation of the team's flight software.
5 stars 0 forks source link

State:updateState() method too hardcoded for 6 dimensional kalman filters #57

Open mallamacimj opened 2 months ago

mallamacimj commented 2 months ago

We should put this onto the end user.

DrewBrandt commented 1 month ago

I believe the idea was to provide a working implementation that people could just "plug and play". If they wanted to explore other options for the KF, they would override the updateState() method. It may be better to break the kalman step into its own function so that it's more obvious which part of updateState() might need to be overridden if the rest of the method is still valuable