search

Terrastories / terrastories

Terrastories is a geostorytelling application for mapping, managing and sharing place-based stories.
https://terrastories.app
MIT License
319 stars 157 forks source link

[Tests] Let's get to 100% Test Coverage! #276

Closed kalimar closed 4 years ago

kalimar commented 5 years ago

Terrastories is a very scrappy, amazing application that is starting to grow-up. With that in mind it's time to start providing test coverage. We could use help with the following:

This milestone will be considered reached when the above checklist is completed.

Reference notes I've installed the simplecov gem on my computer but even code that reports as having 100% coverage doesn't have passing specs. I've installed simplecov using these instructions, and here is how I am executing it's commands:

Running the test suite on the docker container

$ docker-compose run web scripts/wait-for-it.sh db:5432 -- "rspec spec"

Viewing coverage

$ docker-compose up $ docker exec terrastories_web_1 /bin/bash $ open coverage/index.html

sleekybadger commented 5 years ago

@kalimar Hi. I opened https://github.com/Terrastories/terrastories/pull/309 which improves simplecov configuration a little bit. What do you thinking about free CI integrations (for example travis-ci, codecov, etc)?

kalimar commented 5 years ago

Yeah we definitely want to have something like Travis. Do you want to scope out a ticket? I'm going to add Javascript specs too